Welcome, Guest
Username: Password: Remember me
08 Apr 2018
INDI development team is happy to announce the release of INDI Library v1.7.0. This new exciting release builds on the maturity of INDI Library and comes with many new supported devices and fixes for existing drivers.
Read More...
  • Page:
  • 1
  • 2

TOPIC: EQMOD driver causing phd2 to segfault

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #18923

  • kengs
  • kengs's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 83
  • Karma: 1
  • Thank you received: 16
I posted over at the phd2 forum about a crash when the button for the INDI control panel is pressed. After investigating its looking more like something in the eqmod driver.
If I connect only to the camera in PHD2 then click the INDI button to open the control panel it works fine. Once I connect to the EQMOD driver the same button causes a segfault. Running phd2 in a terminal shows some strange messages when connecting to EQMOD - see the attachment.Also attached is the output from gdb after rebuilding with debugging. It shows the segfault occurring in a call to removeProperty
Third attachment is indi driver log
The same issue occurs on both Raspberry Pi 3 Ubuntu Mate 16.04 and 17.04 and on Ubuntu VM on x64 16.04. I've updated all software to the latest verions.

File Attachment:

File Name: phd2_indi2.txt
File Size: 4 KB

File Attachment:

File Name: phd2_gdb_vm.txt
File Size: 8 KB

File Attachment:

File Name: indi_eqmod_telescope_12_32_20.log
File Size: 10 KB
Attachments:

Please Log in or Create an account to join the conversation.

Ubuntu 16.04 AMD64, RPi3 Ubuntu Mate 16.04, Windows 8.1 AMD64
EQ6 Pro, Atik420, ASI1600MM-C, ASI120MM-S, DBK21AU04, ZWO EFW
Vixen R150S, GSO RC8, ST80

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #18929

  • pch
  • pch's Avatar
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 69
  • Thank you received: 40
Just to add some more informations.

I have fixed the crash in phd2 by checking null parameter in removeProperty().
Is it expected that baseclient can call removeProperty with a null property?

My eqmod driver do not shot this "Dispatch command error", this is probably related to the null property we receive. Any idea why Ken version do that?

Please Log in or Create an account to join the conversation.

Last Edit: by pch.

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #18950

baseclient is not suppose to call removeProperty with null, I just fixed that. However, this points to a problem with the driver as it tries to delete a property that it hasn't defined yet, so have to look in EQMod as well.

Please Log in or Create an account to join the conversation.

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #18954

  • kengs
  • kengs's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 83
  • Karma: 1
  • Thank you received: 16
Could it be related to the 6 SIMULATORxxx properties it is trying to delete? I have no idea where those are cming from

Please Log in or Create an account to join the conversation.

Ubuntu 16.04 AMD64, RPi3 Ubuntu Mate 16.04, Windows 8.1 AMD64
EQ6 Pro, Atik420, ASI1600MM-C, ASI120MM-S, DBK21AU04, ZWO EFW
Vixen R150S, GSO RC8, ST80

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #19027

  • kengs
  • kengs's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 83
  • Karma: 1
  • Thank you received: 16
I just downloaded PHD2 2.6.3dev7 on Win8.1 (without Patricks fix) and it has the same issue with the INDI button. So its looking pretty clear its the EQMOD driver. Is ther anything I can do to help? I've pulled the indi driver code to have a look but I'm not familiar with how it all hangs together.

Please Log in or Create an account to join the conversation.

Ubuntu 16.04 AMD64, RPi3 Ubuntu Mate 16.04, Windows 8.1 AMD64
EQ6 Pro, Atik420, ASI1600MM-C, ASI120MM-S, DBK21AU04, ZWO EFW
Vixen R150S, GSO RC8, ST80
Last Edit: by kengs.

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #19035

  • pch
  • pch's Avatar
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 69
  • Thank you received: 40
Andy just publish phd2 2.6.3dev8 that include the fix.

I suspect the SIMULATOR* properties get deleted without being created by the eqmod driver when you start with a real mount but not the simulator.
But I am not at home now and have one week more before I can try with my mount.

Please Log in or Create an account to join the conversation.

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #19042

  • kengs
  • kengs's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 83
  • Karma: 1
  • Thank you received: 16
I believe you are right. I've been putting some traces through the driver and phd2 code and it is looking that way.

Please Log in or Create an account to join the conversation.

Ubuntu 16.04 AMD64, RPi3 Ubuntu Mate 16.04, Windows 8.1 AMD64
EQ6 Pro, Atik420, ASI1600MM-C, ASI120MM-S, DBK21AU04, ZWO EFW
Vixen R150S, GSO RC8, ST80

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #19043

  • kengs
  • kengs's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 83
  • Karma: 1
  • Thank you received: 16
The horizon and alignment properties are also not being created (or rather broadcast) as well. What I found is that my trace for those sets of properties (in EQMod::loadProperties() )show up as a popup in Ekos rather than being logged. So I suspect they are being set up before the interface is ready. If that makes any sense

Please Log in or Create an account to join the conversation.

Ubuntu 16.04 AMD64, RPi3 Ubuntu Mate 16.04, Windows 8.1 AMD64
EQ6 Pro, Atik420, ASI1600MM-C, ASI120MM-S, DBK21AU04, ZWO EFW
Vixen R150S, GSO RC8, ST80

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #19057

  • kengs
  • kengs's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 83
  • Karma: 1
  • Thank you received: 16
I've made some changes to my local copy of simulator.h and simulator.cpp
Added a property isEnabled to hold the enablement state of the simulator so that in updateProperties, properties are only removed if they had been previously defined
Made equivalent changes to eqmod, align and scope-limits to hold connection status.
With these changes phd2 no longer receives removal of properties that have not been defined.
Whats the best way to supply the changes? Do I just git push?

Please Log in or Create an account to join the conversation.

Ubuntu 16.04 AMD64, RPi3 Ubuntu Mate 16.04, Windows 8.1 AMD64
EQ6 Pro, Atik420, ASI1600MM-C, ASI120MM-S, DBK21AU04, ZWO EFW
Vixen R150S, GSO RC8, ST80

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #19060

Submit a Pull-Request at INDI Github page .

Please Log in or Create an account to join the conversation.

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info

EQMOD driver causing phd2 to segfault 10 months 2 weeks ago #19063

  • kengs
  • kengs's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Posts: 83
  • Karma: 1
  • Thank you received: 16
Some more new tricks for this old dog to learn :)
Pull request submitted.
The following user(s) said Thank You: knro

Please Log in or Create an account to join the conversation.

Ubuntu 16.04 AMD64, RPi3 Ubuntu Mate 16.04, Windows 8.1 AMD64
EQ6 Pro, Atik420, ASI1600MM-C, ASI120MM-S, DBK21AU04, ZWO EFW
Vixen R150S, GSO RC8, ST80

EQMOD driver causing phd2 to segfault 10 months 1 week ago #19099

I submitted a simpler change, can you please test that?

Please Log in or Create an account to join the conversation.

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info
  • Page:
  • 1
  • 2
Time to create page: 0.200 seconds

Login



3rd Party

Choose from the numerous 3rd party INDI drivers to suit your needs!

Got Problem?

Check out the FAQ, the forum, and the bug tracking system to resolve any issues you might have!
You can also subscribe to INDI newsletter and development mailing lists to get the latest updates on INDI!


Gallery

Replica

Why INDI

Replica