Hi, I'm just setting up a dev environment to try some things with KStars and I've hit a couple of issues with the unit tests on a clean build:
Some unit tests eg. TestPlaceholderPath, TestPolarAlign failed to find the test data files - I had to link these to files in the build/bin directory:
9filters.esq -> ../Tests/scheduler/9filters.esq
ngc4535-autofocus1.fits -> ../Tests/polaralign/ngc4535-autofocus1.fits
ngc4535-autofocus2.fits -> ../Tests/fitsviewer/ngc4535-autofocus2.fits
ngc4535-autofocus3.fits -> ../Tests/fitsviewer/ngc4535-autofocus3.fits
testFlexibleNamingChangeBehavior_data_small.csv -> ../Tests/capture/testFlexibleNamingChangeBehavior_data_small.csv
testFlexibleNaming_data_small.csv -> ../Tests/capture/testFlexibleNaming_data_small.csv
testFullNamingSequence_data_small.csv -> ../Tests/capture/testFullNamingSequence_data_small.csv
testSchedulerProcessJobInfo_data.csv -> ../Tests/capture/testSchedulerProcessJobInfo_data.csv
Test TestFitsData::testComputeHFR (NGC4535-3-NORMAL) fails. It finds 29 stars instead of the expected 30.
Are these bugs in the tests or have I messed up somewhere?
I'd like to have a clean reference before I start digging into the code.
Interestingly, I didn't see any reference to TestFitsData in the pipeline output, not sure why.
I just tried to run that test, and also got failures, so it isn't you.
Clearly we need to look at it. Someone must have disabled it.
Don't have time to look right now.
Be aware that we don't have great test coverage, though it has been improved in the past year. It is certainly an area that would be great to improve.
Thank you for looking into things, and looking forward to see what you come up with.