×
INDI Library v1.8.1 Released (09 Sep 2019)

Monthly maintenance release INDI v1.8.1

Re:Bug in handling the :MS# command in LX200 Basic

3 months 4 weeks ago
wbirk
Expert Boarder
Expert Boarder
Posts: 100
Karma: 3
More
Topic Author
Re:Bug in handling the :MS# command in LX200 Basic #41910
hello!
after working on my telescope controller TSC for a while, I finally came back to solving an issue that bugged me for a while. I had/have the following problem.
  • when connecting to the controller via LX200 Basic, all works fine
  • when issuing a Slew command, the command is carried out but the position display in kstars is wrecked

after playing around in my code, I think i found the reason; "Slew" issues three commands, the desired position Sr and Sd, and a "Slew possible" command, :MS#.
Sr and Sd await a response, 1 if the coordinate is reasonable or 0 otherwise. I respond with "1" to each of these commands. Now here is the strange thing. INDI should
  • send Sr ... and wait for the answer
  • send Sd ... and wait for the answer
  • send MS and wait for the answer

well, it does not; it sends Sd and MS as one command and apparently, does not expect two replies. as a result, the declination string and the RA string are read in the wrong order, and declination and RA are exchanged - which leads to a totally chaotic display, of course.

if i do not reply to :MS# as required in the LX200 protocol, everything is fine ...
yours
wolfi

Please Log in or Create an account to join the conversation.

3 months 3 weeks ago
TallFurryMan
Platinum Boarder
Platinum Boarder
Posts: 737
Karma: 13
More
Re:Bug in handling the :MS# command in LX200 Basic #41947
Nice find. At some point later there must be a flush of the input stream, which "fixes" the garbage remaining in the queue. Do you plan to issue a PR for the generic LX200 protocol handling? Or to override this specific part in your own code?

-Eric

HEQ5-Pro - Atik 314E - Orion ED80T - DMK21 on Orion 50mm
DIY 3D-printed Moonlite and FWheel RGB/LPR
KStars and indiserver on two Atom 1.6GHz 1GB RAM Linux, VPN remote access

Please Log in or Create an account to join the conversation.

3 months 3 weeks ago
wbirk
Expert Boarder
Expert Boarder
Posts: 100
Karma: 3
More
Topic Author
Re:Bug in handling the :MS# command in LX200 Basic #41956
hi!
erm ... i am not familiar with the abbreviation “PR”. There is a workaround since most programs i have tried do not give a ... about the :MS# response, so if it is omitted, at least sky safari, cdc and kstars work fine. but it should be fixed as it is really in the LX200 protocol ...
yours wolfi

Please Log in or Create an account to join the conversation.

3 months 3 weeks ago
wvreeven
Platinum Boarder
Platinum Boarder
Posts: 1113
Karma: 6
More
Re:Bug in handling the :MS# command in LX200 Basic #41957

ASI1600MM-Pro Cooled and filter wheel with a SkyWatcher Esprit 80 ED on a SkyWatcher HEQ5-Pro

ASI1600MM-Pro Cooled and filter wheel with an 8" TS Ritchey-Chrétien on a SkyWatcher EQ6-R

Please Log in or Create an account to join the conversation.

3 months 3 weeks ago 3 months 3 weeks ago by wbirk.
wbirk
Expert Boarder
Expert Boarder
Posts: 100
Karma: 3
More
Topic Author
Re:Bug in handling the :MS# command in LX200 Basic #42136
Hi!
So I shall locate the error and take are of this, and then issue a pull request? or shall i issue a bug report via github.com/indilib/indi/issues?utf8=✓&q=LX200 ?
yours wolfi

Please Log in or Create an account to join the conversation.

3 months 3 weeks ago
TallFurryMan
Platinum Boarder
Platinum Boarder
Posts: 737
Karma: 13
More
Re:Bug in handling the :MS# command in LX200 Basic #42140
You can do both: first you explain the problem in an issue, then you create a fix and push a pull request, then people with LX200 mounts discuss or test the change, then when both dust and arguments settle, the issue can be closed.

-Eric

HEQ5-Pro - Atik 314E - Orion ED80T - DMK21 on Orion 50mm
DIY 3D-printed Moonlite and FWheel RGB/LPR
KStars and indiserver on two Atom 1.6GHz 1GB RAM Linux, VPN remote access

Please Log in or Create an account to join the conversation.

Time to create page: 0.668 seconds