×

INDI Library v1.8.0 is Released (27 Jul 2019)

INDI Library v1.8.0 is mostly a maintenance release to fix a few bugs in several drivers.

Re:Bug in handling the :MS# command in LX200 Basic

  • Posts: 100
  • Karma: 3
  • Thank you received: 19

Bug in handling the :MS# command in LX200 Basic was created by wbirk

hello!
after working on my telescope controller TSC for a while, I finally came back to solving an issue that bugged me for a while. I had/have the following problem.
  • when connecting to the controller via LX200 Basic, all works fine
  • when issuing a Slew command, the command is carried out but the position display in kstars is wrecked

after playing around in my code, I think i found the reason; "Slew" issues three commands, the desired position Sr and Sd, and a "Slew possible" command, :MS#.
Sr and Sd await a response, 1 if the coordinate is reasonable or 0 otherwise. I respond with "1" to each of these commands. Now here is the strange thing. INDI should
  • send Sr ... and wait for the answer
  • send Sd ... and wait for the answer
  • send MS and wait for the answer

well, it does not; it sends Sd and MS as one command and apparently, does not expect two replies. as a result, the declination string and the RA string are read in the wrong order, and declination and RA are exchanged - which leads to a totally chaotic display, of course.

if i do not reply to :MS# as required in the LX200 protocol, everything is fine ...
yours
wolfi
1 week 4 days ago #41910

Please Log in or Create an account to join the conversation.

  • Posts: 728
  • Karma: 13
  • Thank you received: 229

Replied by TallFurryMan on topic Re:Bug in handling the :MS# command in LX200 Basic

Nice find. At some point later there must be a flush of the input stream, which "fixes" the garbage remaining in the queue. Do you plan to issue a PR for the generic LX200 protocol handling? Or to override this specific part in your own code?

-Eric
HEQ5-Pro - Atik 314E - Orion ED80T - DMK21 on Orion 50mm
DIY 3D-printed Moonlite and FWheel RGB/LPR
KStars and indiserver on two Atom 1.6GHz 1GB RAM Linux, VPN remote access
1 week 3 days ago #41947

Please Log in or Create an account to join the conversation.

  • Posts: 100
  • Karma: 3
  • Thank you received: 19

Replied by wbirk on topic Re:Bug in handling the :MS# command in LX200 Basic

hi!
erm ... i am not familiar with the abbreviation “PR”. There is a workaround since most programs i have tried do not give a ... about the :MS# response, so if it is omitted, at least sky safari, cdc and kstars work fine. but it should be fixed as it is really in the LX200 protocol ...
yours wolfi
1 week 3 days ago #41956

Please Log in or Create an account to join the conversation.

  • Posts: 932
  • Karma: 6
  • Thank you received: 239

Replied by wvreeven on topic Re:Bug in handling the :MS# command in LX200 Basic

ASI1600MM-Pro Cooled and filter wheel with a SkyWatcher Esprit 80 ED on a SkyWatcher HEQ5-Pro

ASI1600MM-Pro Cooled and filter wheel with an 8" TS Ritchey-Chrétien on a SkyWatcher EQ6-R
1 week 3 days ago #41957

Please Log in or Create an account to join the conversation.

  • Posts: 100
  • Karma: 3
  • Thank you received: 19

Replied by wbirk on topic Re:Bug in handling the :MS# command in LX200 Basic

Hi!
So I shall locate the error and take are of this, and then issue a pull request? or shall i issue a bug report via github.com/indilib/indi/issues?utf8=✓&q=LX200 ?
yours wolfi
Last edit: 4 days 17 hours ago by wbirk.
4 days 17 hours ago #42136

Please Log in or Create an account to join the conversation.

  • Posts: 728
  • Karma: 13
  • Thank you received: 229

Replied by TallFurryMan on topic Re:Re:Bug in handling the :MS# command in LX200 Basic

You can do both: first you explain the problem in an issue, then you create a fix and push a pull request, then people with LX200 mounts discuss or test the change, then when both dust and arguments settle, the issue can be closed.

-Eric
HEQ5-Pro - Atik 314E - Orion ED80T - DMK21 on Orion 50mm
DIY 3D-printed Moonlite and FWheel RGB/LPR
KStars and indiserver on two Atom 1.6GHz 1GB RAM Linux, VPN remote access
4 days 16 hours ago #42140

Please Log in or Create an account to join the conversation.

Time to create page: 0.409 seconds