×

INDI Library v2.0.7 is Released (01 Apr 2024)

Bi-monthly release with minor bug fixes and improvements

fitsviewer: stretching image causes crash

  • Posts: 969
  • Thank you received: 94
Hi. Your file crashes too. Must be my install. Anything I could try?
TIA
4 years 3 months ago #48496

Please Log in or Create an account to join the conversation.

  • Posts: 1009
  • Thank you received: 133
Not really :(
(and I have to leave now for some ~2h - maybe someone else has suggestions)
4 years 3 months ago #48497

Please Log in or Create an account to join the conversation.

  • Posts: 969
  • Thank you received: 94
Ok. One observation: the icon at the lower right of the fitsviewer window which restores default slider positions is missing in the git version but present in the stable PPA version.
Ubuntu 18.04
4 years 3 months ago #48499

Please Log in or Create an account to join the conversation.

  • Posts: 1222
  • Thank you received: 565
Steve, I'll also take a look. You say it crashes from the most recent git with that file. What computer, OS, other details are you using?

Also, that magic wand icon in the lower right is disabled when the image is already using the automatically computed stretch parameters. It only appears after the stretch has been modified. Perhaps that's what you're seeing?
4 years 3 months ago #48501

Please Log in or Create an account to join the conversation.

  • Posts: 969
  • Thank you received: 94
Hi. Yes, I only see the icon after I move the sliders in the stable version of kstars but in the latest git I never get to see it because moving any of the sliders causes the crash: bt above. It crashes with ANY .fits file whether I created it with a dslr in kstars or not.
Thanks for taking a look.

Ubuntu 18.04 updated
Tried on an intel i3 with 16Gb, an intel i5 with 8Gb both using ssd drives and an AMD E2 with 4Gb and a mechanical hard drive, all using either yesterday's or today's git. The fitsviewer of stable version 3.3.9 works on all three.
TIA
Last edit: 4 years 3 months ago by alacant.
4 years 3 months ago #48502

Please Log in or Create an account to join the conversation.

  • Posts: 1009
  • Thank you received: 133
So if I interpret the crash happens during the display of the scaled-down preview in the upper left (cute feature BTW!), and within some QT GL-routine(?)...
Just to be sure - did you do a full clean build from scratch, or use some old(er) CMake cache?
4 years 3 months ago #48507

Please Log in or Create an account to join the conversation.

  • Posts: 1222
  • Thank you received: 565
FYI, I am also looking at it, and that "cute feature--upper left preview" is actually some kind of bug I'm chasing down, perhaps a clue to the crashes.
I never programmed that, and it didn't happen previously :/

Unfortunately, I'm having issues with my build environment on my mac, so it may be a bit until I can fix that and then start debugging.
4 years 3 months ago #48508

Please Log in or Create an account to join the conversation.

  • Posts: 969
  • Thank you received: 94
Full clean build from nothing. I deleted ~/Projects and started over: same crash with any .fits file. The bt suggests:
home/steve/Projects/kstars/kstars/fitsviewer/stretch.cpp:321
Had something to do with it,but I'm not a coder...
Thanks for your time everyone.
4 years 3 months ago #48511

Please Log in or Create an account to join the conversation.

  • Posts: 969
  • Thank you received: 94

To reproduce the crash:
1. Open a . fits file in fitsviewer
2. Move one of the three sliders at the bottom of the fitsviewer window.
result: kstars crashes

Thanks again,
Steve
Last edit: 4 years 3 months ago by alacant.
4 years 3 months ago #48513

Please Log in or Create an account to join the conversation.

  • Posts: 1009
  • Thank you received: 133

Oops :whistle:
So maybe some change in the QT libraries? What are you using? I had just updated to 5.14
4 years 3 months ago #48516

Please Log in or Create an account to join the conversation.

  • Posts: 1222
  • Thank you received: 565
I found a (my) bug the fitsview code, and submitted a change for Jasem's review. phabricator.kde.org/D26910
I'm not sure that this is causing the crashes, I wasn't able to reproduce them,
but I suppose it's possible. It does, however, clear up the "cute feature--upper left preview" ;)
Steve: once this is submitted (after Jasem's review), please retest. I'll post here when I see that it's in the latest kstars code.
Sorry about that,
Hy
4 years 3 months ago #48522

Please Log in or Create an account to join the conversation.

  • Posts: 1222
  • Thank you received: 565
It is now submitted, so if you git pull and compile, you'll have the fix.
Not sure when it gets to the nightly release? A day or so?
Please test and let me know.
Hy
The following user(s) said Thank You: alacant
4 years 3 months ago #48524

Please Log in or Create an account to join the conversation.

Time to create page: 0.773 seconds