Ok Jasem, thanks for your feedback. I was misled by the indi web page regarding this focuser that suggests that the driver is available.
Pierre-Yves

It is available in the INDI Nightly Builds.

The documentation says it is available INDI Library >= v1.8.2

Current stable INDI version is v1.8.1

Sorry, I did'nt pay attention to the Indi release numbering.
Thanks Jasem.

I've double checked the code and it looks like everything is as intended. Tested too!

Thanks Alan

About to run some sanity test on the latest MyFP2 indi driver build (version 3) against the v2.91 focuser firmware

Before I run any tests, I took a quick look at the MyFP2 indi driver source code on git

You mentioned that:

" I will then make the base firmware check equal to or greater than 291."

It looks like the minimum firmware version check is as follows:



Is this as intended?

Ah, I see the issue now

The commit for myfocuserpro2.h on your git fork
github.com/ajt68/indi/tree/master/drivers/focuser

is ahead of the commit on
github.com/indilib/indi/tree/master/drivers/focuser

OK lets regroup, my last commit is not what was intended!!!

I did a merge and believed I made the correct changes, then committed and did a pull, at which time I was told I was up to date. So I assumed because my changes were correct at my end, then that is what was committed.

I have just realised this is not the case, and the only change was the version number!!!??? This was discovered whilst setting up an AstroBerry, and pulling the latest nightly, I noticed my changes were not there.

So I have two file on my development end, that need to be committed via a pull request?
I guess the steps are
1. Create a commit (should I do some sort of sync first, and if so what should I do?).
2. Create a Pull Request at the head end, and associate the above commit?

I won't do anything until I get some feedback, as this is how I started getting in this mess, and can't understand why only the version number was committed?

TIA.

So no feedback on what to do so I have just tried another commit and pull request and again a conflict, but I think I have now pushed/pulled the code I intended (version 0.4)

Nice one Alan

I see your (v 0.4) commits from yesterday on your git fork to the following code files:

myfocuserpro2.h
myfocuserpro2.cpp


Just waiting for these to be reflected in the main branch now

Perhaps Jasem can support on that

I merged the PR, can you check now?

I have visually checked the main master branch code, and it looks like all my changes are in.

Hi Alan

I really appreciate your efforts.

In terms of myfp2, the standard should be that commands are :xx and terminated with #, commands being 2 characters long (maybe followed by parameters of variable length). This shouldve been consistent from 2014 and I cannot really understand when and if it ever changed to less than 2 [in which case the firmware wouldve rejected the command]
You can rest assured this will not change.
There is as I understand it, no plans to add or change commands in the forseeable future. There should be no reason to change the test for firmware version (at 291) for any future release. At present there are also no plans to add additional features in the pipeline, for 2 reasons - we are running out of space, and effort is now redirected to use the esp8266/esp32 based chips (which solves issue1 running out of space).

v292 is in testing but its only cosmetic changes.

Hope this helps
regards
Robert