Ok, I was able to confirm the CSV issue. A Windows CSV file must be converted to match Linux path convention. So, for example, each C:\Users\Image\blah line on PC must be converted to /home/Image/blah before AD will work correctly. Once I did this, AD was able to find the associated image file and import it (with correct results).

Not sure if you want to add a feature for this architecture nuance or not. Windows users can just push the CSV file to linux and run a script to convert, but it would be nice to have a "setting" for architecture specific CSV path conversion. If you do address it, I suggest two strings (from, to) as this will kill architecture AND any mount point naming differences.

Edit: Or as you say, run both from consistent architectures. I like the flexibility of a conversion string setting in AD, but now that we have mitigation(s), it's not a show-stopper.

Fantastic! Looking forward to using this.
Thanks for contributing.
Jo

hi Doug,
so you can see the charts now? good.
As you uploaded quite and amount of data, the app slowed down? I had up to 2000 images in the same db and it was ok.

I will release a new version tomorrow or the day after. Window resizing was tricky and also saving column width had some issues: saving columns was preventing the hide/show column to work properly.

Cheers
Ferrante

Uploaded on pypi a new version (0.2.7) that implements several suggestions mainly by Doug:
- Resize windows
- Save session for imagelist columns width and for window size and position
- Format RA/DEC, Alt/Az, Lat Long
- Precision (even though precision is affected by FITS header precision)
- Delete rows



Note about upgrading:
Please use a different virtual environment for testing if you previously installed AstroDom; or save your /astrodom/config files because installing in the same venv or using the upgrade.sh script will override some config files.
These are the config files affected:
- demo.db: no harm if you uploaded images to a different database
- config.json: upgrade will reset the active database selection
- profile-Ekos and profile-MaximDL: if you saved your own profile it will be ok.Else custom keywords will be overridden.


ferrante

Ferrante, I've updated to your latest. Thanks! The changes work as expected (I was able to save the changed field sizes, and resize the GUI). Much better. I am still getting a core dump on at least one specific use case. If you start to import a CSV file, but instead of following though, you "cancel" before loading the file, the app will core dump consistently. Here's the trace:

Traceback (most recent call last):
File "/home/dsummers/src/archive/AstroDom-master/resources/venv/lib/python3.8/site-packages/astrodom/importCsvTab.py", line 67, in importCsvFile
for row, val in enumerate(dataTemp):
UnboundLocalError: local variable 'dataTemp' referenced before assignment
./astrodom_linux_run.sh: line 18: 391996 Aborted (core dumped) python3 -m astrodom

I doubt this is a python3 thing.....probably want to chase that.

Cheers, Doug

Hi Doug, I noticed that error too. It s already fixed in 0.2.9 and pushed to github repo and pypi.
Thanks for your feedback.
Edit: it was not related to python3, I simply forgot to check for an empty selection when the file widget is closed .

So, before I do my own CSV path string conversion from Windows to Linux, are you sure you don't want AD to be architecture independent for this particular detail? Grabbing the path string from the CSV and converting to local form for all might be better than me doing this for myself only... As I said before, the preferred method would be two strings (to,from) to accommodate filesystem mount point differences.

A second question for you is whether the astrodom_linux_upgrade.sh script down in resources works correctly for minor updates. I did the full pull/install last time, and if the update script works more simply for minor patches like this latest one, that would be preferred. Can you comment on that script? Thanks.

The upgrade script works the same way as install except the first doesn't recreate the 'venv' virtual environment. So yes, it is more suited for small updates . Just be aware that the config files will be overwritten in both cases, so prepare a back up ( I will fix this soon because it's annoying ). The database should not be affected but I would do a backup in any case.

Ok I will implement the path conversion because it happens quite often to move files around. It will be set in the settings tab and in the csv tab you can check/uncheck if conversion has to be applied.

now with v 0.2.11 you can replace (part) of a path to search for CSV file.
Path input is in CSV import tab. Was a better location than Settings.

Usage example:
Actual FITS file is on Windows: C:\users\ferrante\IC434\Luminance\test.fits
CSV file was made when on Linux: /home/ferrante/IC434/Luminance/test.fits
So replace From: /home/ferrante/
To: C:\users\ferrante\

- It works the other way around too (FITS saved on Linux, CSV on Windows) and of course with both coming from the same OS.
- Don't worry about creating mixed path like C:\users\ferrante\IC434/Luminance/test.fits AstroDom will fix it.
- It relies on a function that detects the OS separator. Only tested on Linux, hope it works on Windows too.
- If From is not empty while To is, replace is still applied with an empty string. If From is empty no replacement is applied.

Ok! Now we're talking. Congrats on a very nice project. I confirm platform independence works for CSV file paths via the conversion strings. Having PI stats with DB search/filters is very nice. I'll look forward to having a few more important fields in the future (focus position, focus HFR, seeing, etc.). I'd recommend a CSV interface for those fields too, with keywords TBD.

A couple more thoughts. Currently, when you double click on an image, a Details View pops up. I recommend reducing white space between fields (minimize vertical space). Next is the image viewer. Can you support association (via settings) for launching a different viewer? If so, this would really amp up presentation. The kstars FITS viewer would be an ideal candidate to allow. It's very nice for OSC subexposures. Images are nicely stretched and colored with bells/whistles for movement etc. The current viewer could serve as a good default....

In any case, even if you can't associate/launch another viewer, at this point, I will use AD and recommend it to others as well. Good Job! Cheers, Doug

thank you Doug! your feedback has been really valuable.

As you say, there are many other software that are already good at showing images, I will not try to replicate them. Launching an external viewer seems the best option, even if I had issues when I tried to open external softwares from AD. For example it was a good idea to open a file browse pointing at the directory containing the file when clicking on its name. But on Linux I struggled to find how to do it.

Reducing the interline in the details window will result to be less readable. What if I change layout to landscape orientation? I mean image preview on the left and fields description on a right pane.

cheers,
ferrante

No need to reduce the spacing if it detracts. I suspect changing orientation would be arbitrary too. If you figure out how to launch the Kstars FITS viewer on the selected filename (and probably want to limit this to some number 1-5 to avoid user select mis-steps), I'd say maybe the next thing to consider might be a CSV data export (for user selected lines & columns). This enables other tools (Python, Excel, etc) to take advantage of the growing info content of DB fields.

If you do decide to add CSV export, I would recommend you add both row index selector and column selector. There's no current row index (but users can mouse select/drag). Selecting a column is currently reserved for sort order (asc/decend). A minimum column rectangle above each column heading could serve to allow users to select the entire column contents. On row index, folks are so used to seeing line number, I'd just include it and use it as the entire row selector.

BTW, I couldn't figure out how to see hidden fields after hiding, then unchecking. How is that accomplished? If no auto-refresh on the GUI, then should a refresh button be added to see the fields again?