×

INDI Library v1.9.7 Released (29 Jul 2022)

Bi-monthly INDI Library released with new drivers and bug fixes.

Meridian Flip - EKOS/Onstep Slews to last star

  • Posts: 148
  • Thank you received: 19
Ok so I can simply do both - that will capture it either way 3.x or 4.x..would need a body to test it however

else if (strstr(OSStat, "n") && !strstr(OSStat, "N"))
{
//set from state above
TrackState = SCOPE_SLEWING;
IUSaveText(&OnstepStat[1], "Slewing");
}
else if (!strstr(OSStat, "n") && !strstr(OSStat, "N"))
{
//set from state above
TrackState = SCOPE_SLEWING;
IUSaveText(&OnstepStat[1], "Slewing");
}
11 months 2 weeks ago #74952

Please Log in or Create an account to join the conversation.

  • Posts: 300
  • Thank you received: 24
I like this catch all code.

Add a comment to each case, saying "For OnStep 3.x", and "For OnStep 4.x"
Test it on 3.x and verify that it works there.
Then attach the modified .cpp file so someone can test it.

I hope someone who uses OnStep 4.x and is setup for an INDI build environment can test it today or tomorrow. If not, then I will setup a build env, and do that Sunday or so.
11 months 2 weeks ago #74953

Please Log in or Create an account to join the conversation.

  • Posts: 300
  • Thank you received: 24
I revived my INDI build environment and it is working well.
I did not do "make install" yet, since it will overwrite the official binaries from the package that I have.

When I try to purge the package indi-bin (from Jasem's PPA), it will also remove kstars-bleeding, and I would like to avoid compiling KStars for no reason.
The following user(s) said Thank You: Vrajesh
11 months 2 weeks ago #74956

Please Log in or Create an account to join the conversation.

  • Posts: 7
  • Thank you received: 1
I am glad you guys found a solution. I wish I can help you test this out but my skills in programming and Linux are lacking a bit. I'll have to wait till the official release.
11 months 2 weeks ago #74966

Please Log in or Create an account to join the conversation.

  • Posts: 300
  • Thank you received: 24
Jamie,

I contacted Jasem, and he told me how to manage a partial environment where kstars-bleeding is from his PPA repos, and INDI is compiled from source.

So, I am ready to test what you have on 4.x, which you already tested with 3.x.

Attach the lx200_OnStep.cpp file with your modifications, and I will try it, then push the changes so they make it into the next release from the repos.
11 months 2 weeks ago #74972

Please Log in or Create an account to join the conversation.

  • Posts: 148
  • Thank you received: 19
sure - attached - this traps for both 3x and 4 x style - change the .txt to .cpp and let me know what you see 

File Attachment:

File Name: lx200_OnStep.txt
File Size:138 KB
11 months 1 week ago #74974
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 148
  • Thank you received: 19
FYI - More testing on my side and still good - all stars and targets listed correctly - all mount movement is immediate and status updated correctly - MF test results: ALL good - slewing reported on all tabs and tools that look at it - mount movement excellent - markings in the mount panel are accurate (flip completed, flip started etc)....I call this a win - just need your 4.x test and I can re-post this multi-version code
11 months 1 week ago #74975

Please Log in or Create an account to join the conversation.

  • Posts: 300
  • Thank you received: 24
I don't understand that part: "just need your 4.x test and I can re-post this multi-version code".

I assumed the file you attached is already multiversion. No?
11 months 1 week ago #74976

Please Log in or Create an account to join the conversation.

  • Posts: 300
  • Thank you received: 24
I tested the file you posted. I had to massage it to remove carriage returns.

It behaves normally on 4.x:
- The target in Ekos is now the star that is being slewed to, even though the slew is still in progress. It is no longer the previous star.
- The popup notification that the mount has reached the target only happens when the slew has actually ended.
- The 'Eq. Coordinates' in INDI goes yellow when the slew is in progress, and then green when the slew ended.

So all good on my side.

We need this to go into INDI's repo quickly, because it affects lots of people, not just those who do meridian flips.

Do you want me to submit it to Jasem?
11 months 1 week ago #74977

Please Log in or Create an account to join the conversation.

  • Posts: 148
  • Thank you received: 19
I have attached the cpp for you to compile and run - I am waiting on your results against your 4.x OnStep code - I only have 3.x installed to run against - HTH
11 months 1 week ago #74978

Please Log in or Create an account to join the conversation.

  • Posts: 148
  • Thank you received: 19
pull request submitted and was already in the works...now updated
11 months 1 week ago #74979

Please Log in or Create an account to join the conversation.

  • Posts: 300
  • Thank you received: 24
Jamie,
Please update the pull request to include the attached code.
It is the same functionality as yours, but minus the Windows vs. Linux line ending (carriage return removed).
Also, the comments are in the correct place (on the condition line), so easier to read.
11 months 1 week ago #74980
Attachments:

Please Log in or Create an account to join the conversation.

Time to create page: 0.822 seconds