Welcome, Guest
Username: Password: Remember me
25 Jul 2018
Glad to announce of release of INDI Library v1.7.4 on 2018-07-25. A few drivers were added in this release as we continue to improve & stabilize existing drivers.
Read More...
  • Page:
  • 1

TOPIC: Eqmod alignment cleared when a new client is connected

Eqmod alignment cleared when a new client is connected 1 year 1 month ago #18698

  • pch
  • pch's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 69
  • Thank you received: 41
I have a problem with the Eqmod alignment data that are cleared when a new client is connected or an existing client send <getProperties version='1.7'/>
This is using the last version from the ppa: 0.3+r3339~201708231229~ubuntu17.04.1

To reproduce the problem :
- start indiserver indi_eqmod_telescope
- connect to real mount or the simulator
- set sync-mode to Add point on sync
- slew and sync to three stars, you see Number of point=3 triangles=1
- connect with telnet and send <getProperties version='1.7'/>
- you get an error message about AlignData.xml file not found
- slew to a new star and sync, you see Number of point=1 triangles=0

I not tested but maybe if AlignData.xml is present you can get the old alignment data ?

Any idea where to search for the problem? I am a bit lost with the alignment code.

Please Log in or Create an account to join the conversation.

Eqmod alignment cleared when a new client is connected 1 year 1 month ago #18709

I think the problem is in line #107 of align.cpp where it initialize the variables, but this shouldn't be called more than once in the session. Jean-Luc should be able to explain more.

Please Log in or Create an account to join the conversation.

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info

Eqmod alignment cleared when a new client is connected 1 year 1 month ago #18725

  • pch
  • pch's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 69
  • Thank you received: 41
Thank you Jasem.

Align::Init() is only called by Align::updateProperties().
This let me trace the problem to align->updateProperties(); called by EQMod::ISGetProperties at line 399 of eqmod.cpp.
Commenting this line fix the problem.

The AlignData.xml is still loaded the first time by align->updateProperties from EQMod::updateProperties at line 669

Do the other thing in Align::updateProperties() must be done by EQMod::ISGetProperties() ? ,
maybe the telescope->deleteProperty part when we disconnect?
In this case the call to align->updateProperties(); can be moved out of the if (isConnected()) block in EQMod::ISGetProperties?

Please Log in or Create an account to join the conversation.

Last Edit: by pch.

Eqmod alignment cleared when a new client is connected 1 year 1 month ago #18726

  • pch
  • pch's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 69
  • Thank you received: 41
I add a few more IDLog and see my last suggestion is not necessary, EQMod::updateProperties call align->updateProperties when the telescope is disconnected.

So in my opinion line 396 to 401 of eqmod.cpp can be removed, but it is probably best to wait Jean-Luc advice.

Please Log in or Create an account to join the conversation.

Eqmod alignment cleared when a new client is connected 1 year 1 month ago #18728

  • pch
  • pch's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 69
  • Thank you received: 41
I normally not save my alignment data because I use a mobile setup, but testing for this issue I found a problem with the way the AlignData.xml is saved.
I make a PR with the fix: github.com/indilib/indi/pull/341
The following user(s) said Thank You: geehalel

Please Log in or Create an account to join the conversation.

Eqmod alignment cleared when a new client is connected 1 year 1 month ago #18902

Thanks Patrick for pointing out those issues and fixing the file loading problem.
On my side I think I've fixed the issue concerning the initialization of the pointset. Made pull request 347 .
Actually this error may also concern horizon limits, I'll have to check.
Jean-Luc.
The following user(s) said Thank You: pch

Please Log in or Create an account to join the conversation.

Eqmod alignment cleared when a new client is connected 1 year 1 month ago #18930

  • pch
  • pch's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 69
  • Thank you received: 41
Thank you Jean-Luc!

I tested your change and everything work fine.

I not use horizon limit but I can give it a try.

Please Log in or Create an account to join the conversation.

Eqmod alignment cleared when a new client is connected 1 year 1 month ago #18931

  • pch
  • pch's Avatar Topic Author
  • Offline
  • Senior Boarder
  • Senior Boarder
  • Posts: 69
  • Thank you received: 41
Just try the simulator with horizon limit.

I set 4 points and write the file.
Then connect a new client (phd2)
I can confirm that the list is reset as after adding a new point it show: Rank=0 (Total 1 points)

Please Log in or Create an account to join the conversation.

Eqmod alignment cleared when a new client is connected 1 year 1 month ago #18955

Yes, same error here. Fixed in PR 354 . ~/.indi/horizonData.txt file is also loaded on first connection now, if it exists.
Thanks.
The following user(s) said Thank You: pch, TallFurryMan, xsnrg

Please Log in or Create an account to join the conversation.

  • Page:
  • 1
Time to create page: 0.144 seconds

Login



3rd Party

Choose from the numerous 3rd party INDI drivers to suit your needs!

Got Problem?

Check out the FAQ, the forum, and the bug tracking system to resolve any issues you might have!
You can also subscribe to INDI newsletter and development mailing lists to get the latest updates on INDI!


Gallery

Replica

Why INDI

Replica