Still in the process of getting the outputs done.

I went hunting a little, and found a few things that could be improved. They are now in main repository. (There was a timeout after tracking On/Off, Parking?, The OnStepX focuser type checks had an issue on V3, so I fixed that as well, it'll timeout once there.)

There may be more, I need to look at some of the replies, the main issue is the use of some of the lx200 functions which expect a # string, and OnStep returns either a single character vs a # terminated string, or in some cases times out. I think I've gotten most of them, with V3 to V5.

I also changed the high precision to be off, and implemented the most basic version checking. It will turn on High precision on connect if it sees OnStep, or On-Step and V4 or V5 or in the case of OnStepX. Otherwise it's off with no timeout caused. If you are using an old version of V4/V5 it might not support that in which case it will cause a timeout (once, effectively the same behavior before the changes).

Timeouts that I don't see a way around:
TMC_SPI detection currently is 2 seconds to check for it's presence and a timeout if not present. (This actually will likely go up, as it appears that TMC_SPI which used to be RA+DEC Both or None is per axis now) 


Copying my old todo:
1. Changing the MaxRate replacement (degrees per sec)
2. Intervolometer support
3. Focuser Changes
4. Dew heater
5. Weather support. (Read BME280/etc)
6. Tangent arm support (Plate solve then adjust?)
7. Check backlash values (Changed to allowed to 3600)
8. DC Focuser support (Not sure if that works already or not?) Might need someone who has one to help with this.
9. TMC_SPI reporting support. (I got one for testing, and finally went to put it in on this cloudy night. I unfortunately missed the: You have to have both axis be SPI if one is, so this will be working at some point, but when is a big question. Oops.)
10. Equivalent of MoveAxis support to allow for following satellites. (Kstars issue more likely than OnStep directly, as the custom rates are added in, but Kstars doesn't have a way to send the rates/information, AFAIK)
11. PEC Import/Export
12. Check uses of getCommandString and replace any which might not return with the replacements (getCommandSingleCharResponse/getCommandSingleCharErrorOrLongResponse)
13. Implement checksum for packets See: onstep.groups.io/g/main/topic/27153325

Also, @Jack I just was able to duplicate and found the cause of the Unparking issue, and submitted another pull request a minute ago. It had been set to only read it from a clean state only from when it first connected. After that it would read only specific things depending on the state. (I suspect an artifact from a long time ago, maybe before :GU# had everything including Park status?) I got rid of the conditionals (there is no extra scope communication) so it updates it every update. (Which also isn't perfect (there was/is? a timing bug with KStars on alignment, if it sees a move start, but the status updates), but eh.)

In that case, dome lock was on, so the unlock would fail, but the state would get set to not parked (don't recall what it was, and doesn't matter) but that was/is tracked in the telescope class so it'd go: Hey, you are already unparked. I'll look into it a bit more, in case it's a problem for someone else.
 

Read More...