Ok I pushed the updated driver. This also requires updated Ekos since the client watchdog now uses seconds instead of minutes to be consistent to weather watchdog. So to test, both INDI+KStars must be updated to latest GIT.
Now the watchdog driver has a Client and Weather watchdogs that can toggled. Previously, it was only client watchdog which would trigger shutdown after communication loss with client. Now I added weather watchdog as well.
Regarding mount locking, it's added in Options
So the watchdog driver should be now sufficient without any external clients (Ekos..etc). The watchdog is a driver/client hybrid so it can orchestrate this without requiring any complex inter-driver communication. Please test this and report back any issues. If all goes well, I believe we ought to remove the weather handling in dome class completely. I even think the mount/dome locking policies can be removed and moved to the watchdog driver. The watchdog driver can monitor both drivers and enforce the policy if it detects a violation. But this is another issue, let's tackle it one at a time.
Read More...
RA is in hours, but yeah it's more likely to do with spherical trig. The calculation in Mosaic assumes a flat plane which is only approximate for very small angles and breaks down over large areas. Will have to look at it more in the future unless someone wants to step it to fix that.
Read More...
I am working now on the updated Watchdog driver, which is indeed driver/client combination. I believe with this driver, it removes the whole orchestration complexity required for this shutdown procedure due to weather. I will share the driver once done.
Read More...
Thank you for the detail investigation. This indeed appears to be a bug but I didn't have enough time to investigate it. Maybe you can spot the issue
here
? This is where it's calculating the center points for each mosaic panel.
Read More...
I'm actually thinking that this whole discussion highlights that this management of what shutdown first should be completely left out of the drivers. The INDI drivers should be minimal and do their job. Right now, we have communication between drivers that are trying to perform some complex interlocking shutdown procedure. This should be definitely left out to clients to handle in my opinion. Maybe the whole thing should be removed from INDI drivers.
Nevertheless, there is ONE specific drivers that's whole purpose is to protect these drivers, it's the Watchdog driver. Currently, the watchdog driver performs a complete shutdown if it loses connection with the client. I suppose this driver can be extended to snoop weather data as well. This way, you don't really have to use Ekos (if you want to) to perform shutdown and just let the watchdog driver handles it for it. It would remove all the complex interlocking scenarios we have to account for. Such options could be left out the clients, whether that client in INDI Watchdog driver, or Ekos or CCDCiel ...etc.
Read More...
Yes but it requires some work. I had to introduce a "hack" in Ekos alignment module to compensate for this.
Read More...