it seems working according to the last tests I did (see logs)
Done with CCD simulator, CCD Guide Simulator, Dome Simulator and OnStep.
The Dome parking waits on OnStep in park position and Ekos shuts down only when Dome is really parked.
I will push the changes to my git and continue more complex testing
2021-07-16T11:54:47 Shutdown complete.
2021-07-16T11:54:47 Ekos stopped.
2021-07-16T11:54:46 INDI devices disconnected.
2021-07-16T11:54:43 Dome parked.
2021-07-16T11:54:26 Parking dome...
2021-07-16T11:54:25 Mount parked.
2021-07-16T11:53:39 Parking mount in progress...
2021-07-16T11:53:38 No jobs left in the scheduler queue.
2021-07-16T11:53:37 Job 'Thuban' is complete.
2021-07-16T11:53:16 Job 'Thuban' capture is in progress...
2021-07-16T11:53:16 Job 'Thuban' slew is complete.
2021-07-16T11:52:24 Job 'Thuban' is slewing to target.
2021-07-16T11:52:21 Mount unparked.
2021-07-16T11:52:19 Dome unparked.
2021-07-16T11:52:13 Unparking dome...
2021-07-16T11:52:12 INDI devices connected.
2021-07-16T11:52:12 Ekos started.
2021-07-16T11:52:07 Scheduler started.
Tested in real conditions with Kstars and CCDciel ...
- Your indi_lx200_OnStep
- Modified RolloffIno
- Snapcap for the flat panel
- ZWO drivers for the two CCD and the filter wheel
- WeatherRadio for weather conditions
It works \ o / Thanks
Kstars automatic sequence:
- Unpark dome
- Open cap
- Unpark mount
- Goto star
- 3 pictures Red
- 3 pictures Green
- 3 pictures Blue
- 3 flats (Luminance filter):
Parameters for flats in Kstars:(Dust cover with external flat light, Park mount, Park dome)
* Park dome
* Park mount
* Switch on the flat panel
* 3 shots.
* Switch off the flat panel
- 1 dummy flat to change the filter (Dark filter) (You cannot choose a filter for darks in Kstars).
- 3 bias
- 3 darks
- Warm CCD, close cap, (mount and shelter already parked by the flat sequence).
End of sequence without error.
Given your changes, I'd like you to look at the own-goto branch as it now has the changes so there should be NO status set from base classes. So it should be only update by our update, and should be consistently reported, and avoid the TrackState IDLE after a park.
I apologize for being quiet, and stepping on your toes about it, but I think it's actually a better solution. Unfortunately a lot of that delay was me upgrading and various changes. (Mostly related to me compiling things outside the package manager, and forgetting, plus resolving what turned out to be insofar as I can tell, a bit error on my SSD. (I don't think I've knowingly encountered that ever on a HDD, but might have if it's in data that's not processed by computer.)
The one change that I don't have in that branch is the Focuser hiding, but that seems to be pretty simple to add back in.
Unfortunately, KStars/Ekos does not pull directly from TrackState, so that didn't resolve the mount model issue. However, digging into it, it relies on EqNP's status as part of the Update using the TrackState. I've added updating that to the section after TrackState, so that should always be good as well. So finally solved? (Maybe.)
So far in my testing, That has eliminated all IDLE states when it's not actually idle except the very initial connect, and so far all instances of the Mount Model taking an instant photo. (Using an OnStep board, and CCD simulator, so that's limited testing and of course things are supposed to be not conducive to testing in the real world for a bit. ) So I think all of that is fixed, but not 100%. I do know in one case with TrackStateSP, there's something lower down that wants to modify it if slewing, so I had that only update if SCOPE_TRACKING to be on.
Anyway, Sorry for going quiet, now trying to catch up on some more things. (So I may be quiet again for a few days.)
we have an Old Story from Mr "Jean de La Fontaine" called the Haze and the Turtle.
So going slow and safe is also my view, otherwise I would have pushed to Indi Directly.
We can wait for pushing to Master for two reasons:
- Lamba use most probably do notice nothing because they do not use advanced features
- Advanced users can test your or my branch and test it if they want.
First test of your onw-goto is promising.
Everything worked fine.
I continue testing and review your code
2021-07-20T18:17:10 Shutdown complete.
2021-07-20T18:17:10 Ekos stopped.
2021-07-20T18:17:09 INDI devices disconnected.
2021-07-20T18:17:06 Dome parked.
2021-07-20T18:16:49 Parking dome...
2021-07-20T18:16:48 Mount parked.
2021-07-20T18:16:47 Warning: mount park operation timed out on last attempt.
......... a lot of waiting since meridian flip before parking
2021-07-20T18:14:53 Warning: mount park operation timed out on last attempt.
2021-07-20T18:14:52 Parking mount in progress...
2021-07-20T18:14:52 Warning: mount park operation timed out on attempt 4/5. Restarting operation...
2021-07-20T18:14:51 Parking mount in progress...
2021-07-20T18:14:51 Warning: mount park operation timed out on attempt 3/5. Restarting operation...
2021-07-20T18:14:50 Parking mount in progress...
2021-07-20T18:14:50 Warning: mount park operation timed out on attempt 2/5. Restarting operation...
2021-07-20T18:14:49 Parking mount in progress...
2021-07-20T18:14:49 Warning: mount park operation timed out on attempt 1/5. Restarting operation...
2021-07-20T18:13:48 Parking mount in progress...
2021-07-20T18:13:47 No jobs left in the scheduler queue.
2021-07-20T18:13:46 Job 'Navi' is complete.
2021-07-20T18:13:25 Job 'Navi' capture is in progress...
2021-07-20T18:13:25 Job 'Navi' slew is complete.
2021-07-20T18:10:17 Job 'Navi' is slewing to target.
2021-07-20T18:10:14 Mount unparked.
2021-07-20T18:10:12 Dome unparked.
2021-07-20T18:10:06 Unparking dome...
2021-07-20T18:10:05 INDI devices connected.
2021-07-20T18:10:05 Ekos started.
2021-07-20T18:10:00 Scheduler started.
I just tested with my setup.
I am unable to unpark the mount.
With the azwing driver the position of the mount on the map is correct and I can unpark the mount.
With the james-lan driver, the position of the mount on the map is wrong and I cannot unpark the mount.
I deleted the xml files just in case.
I will find out where it can come from.
Strange, I just made a test to reproduce your observation.
When I start Kstars and then Ekos I see the telescope where it should be and I have no problem with unparking.
Which xml files are you speaking about?
My park position is 0° alt and 0° az (telescope horizontal).
For the two drivers, in the mount tab, position is bad before unpark. But the reticle is good with your driver and not in the james driver.
It's very strange...
Same issue with Skychart (Cartes du ciel): Position is ok with your driver, not ok with james driver.