×

INDI Library v1.9.8 Released (29 Sep 2022)

Bi-monthly INDI Library released with new drivers and bug fixes.

New Focus Algorithm in Ekos

  • Posts: 37
  • Thank you received: 4

Replied by Sergio on topic New Focus Algorithm in Ekos

Wow, this new algorithm fits perfectly what I was proposing here only 4 months ago (and you also had already in your mind by then) and even more that I didn't think of!! (different curves, weighting by HFR stdev, ...) Last night I gave it a try and it went quite smooth! I can afford to make focus exposures longer to get better SNR and even so, autofocus takes way less than before. Thanks so much for your effort, for me this is quite an improvement.

Playing with the parameters I occasionally ended up with a failed autofocus, that was quite expected as I pushed some of them. But although the log reflects the failure, it doesn't show why it failed:
[2022-06-25T23:46:39.443 CEST INFO ][     org.kde.kstars.ekos.focus] - "Linear autofocus algorithm aborted."
[2022-06-25T23:46:39.445 CEST INFO ][     org.kde.kstars.ekos.focus] - "Autofocus failed, moving back to initial focus position 5.448."
In this case, I guess it didn't meet the minimum R2 I configured, but I think it would be desirable if the failure reason gets logged.

Also, the Analyze tab didn't plot any HFR measurements in the graph, and "Iterations: 0" is shown under Details (in the log I see that this particular autofocus run took 9 HFR measurements).

Thanks again!
5 months 1 week ago #83833

Please Log in or Create an account to join the conversation.

  • Posts: 184
  • Thank you received: 46

Replied by John on topic New Focus Algorithm in Ekos

Thanks very much for the feedback Sergio. If you configure logging like this:


Then you'll get all the focus related messages. For an R2 failure you should get:
2022-06-26 12:49:09.983722+0100 kstars[11402:2349276] [org.kde.kstars.ekos.focus] "Linear Curve Fit check failed R2=0.999893 R2Limit=1 retrying..."

After the rerun you'll get something like this...
2022-06-26 12:50:00.620048+0100 kstars[11402:2349276] [org.kde.kstars.ekos.focus] "Linear Curve Fit check failed R2=0.997972 R2Limit=1, but continuing..."

I suppose your point is that it could be a bit more obvious as to why the rerun happened (as opposed to having to go hunt through a detailed log file). Good point, I'll have a look at this.

In the Analyze tab you should get a focus entry for each autofocus run. If the run is successful it should log all the datapoints. If it fails, it will log the fact that there was an autofocus run but not the datapoints. L1P just fits in with the existing Analyze workflow here. This is how it works for the existing focus algorithms.

If you post the log here I can take a more detailed look.
5 months 1 week ago #83835
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 37
  • Thank you received: 4

Replied by Sergio on topic New Focus Algorithm in Ekos

Thanks John for your prompt answer. Truth is I even didn't think of enabling the debug logs... I was expecting these messages to appear in the status (bottom) panel of the Focus tab.
Yes, in the Analyze tab I do see the successful runs correctly. Sorry I didn't compare the failure case with the other algorithms, of course you're right.
Thanks for your time!
5 months 1 week ago #83837

Please Log in or Create an account to join the conversation.

  • Posts: 184
  • Thank you received: 46

Replied by John on topic New Focus Algorithm in Ekos

I've added the R2 fail messages to the status panel. I need to go through the other msgs and review where they are going. I don't know how long it will be before this gets into the nightly builds.
The following user(s) said Thank You: Jasem Mutlaq, Sergio
5 months 1 week ago #83842

Please Log in or Create an account to join the conversation.

  • Posts: 37
  • Thank you received: 4

Replied by Sergio on topic New Focus Algorithm in Ekos

No problem at all, the algorithm is totally useable as is.
Many thanks John!
5 months 1 week ago #83857

Please Log in or Create an account to join the conversation.

  • Posts: 964
  • Thank you received: 128
I used L1p yesterday for my (automated) observations. Looking at the analyze log, it always found a reasonable focus, even in bad conditions (I did have quite a lot of wind last night :( ). I strongly doubt any of the other algorithms would have found something better. For that, probably some machine learning would be needed (my brain BI would have picked slighly different values in some cases :cheer: )

All in all a very valuable addition!
openSUSE Tumbleweed KStars git INDI git
GPDX+EQMOD, CEM60EC, ASI2600/1600/290mini+EFW+EAF
The following user(s) said Thank You: John
5 months 1 week ago #83858

Please Log in or Create an account to join the conversation.

  • Posts: 202
  • Thank you received: 45

Replied by nou on topic New Focus Algorithm in Ekos

Just did quick test of this and it is really good addition.
The following user(s) said Thank You: John
5 months 3 days ago #83959

Please Log in or Create an account to join the conversation.

  • Posts: 134
  • Thank you received: 13
Just doing a first session with the Linear 1 pass and it works like a charm! First time I get really reproducible focus values and a focus run takes only half the time… Also, using weights for fitting is really a good thing to do!

Thanks John for the valuable extension!

CS, Bernd
254/1450 mm Newton, 130/730 mm APO, 70/336 mm APO, EQ6-R, ZWO EAF focusers, DeepSkyPro 2600c, ASI183MM, Intel NUC 8i5, Ubuntu 22.04
The following user(s) said Thank You: Jasem Mutlaq, John
5 months 2 days ago #83988

Please Log in or Create an account to join the conversation.

  • Posts: 60
  • Thank you received: 7

Replied by Damian on topic New Focus Algorithm in Ekos

Do we know when this will make it from nightly to stable PPA please ?
I'd love to try the Linear 1 Pass but I cause enough problems of my own with my rig, without adding the nightly code into the picture ;)
WO ZS61 II, ASI183MC Pro, ZWO 120MM-S Guider, ZWO EAF, HEQ5 Pro, INDI/EKOS on Ubuntu 20.04
4 months 4 weeks ago #84076

Please Log in or Create an account to join the conversation.

  • Posts: 184
  • Thank you received: 46

Replied by John on topic New Focus Algorithm in Ekos

The plan is that 3.6.0 (which will include L1P) is released 29th July.
The following user(s) said Thank You: Damian
4 months 4 weeks ago #84080

Please Log in or Create an account to join the conversation.

  • Posts: 60
  • Thank you received: 7

Replied by Damian on topic New Focus Algorithm in Ekos

Fabulous. Thank you John
WO ZS61 II, ASI183MC Pro, ZWO 120MM-S Guider, ZWO EAF, HEQ5 Pro, INDI/EKOS on Ubuntu 20.04
4 months 4 weeks ago #84082

Please Log in or Create an account to join the conversation.

  • Posts: 964
  • Thank you received: 128
John, I have a question.
Actually, it was more than one, fortunately I first read through your PDF more carefully, which answered them... :whistle:
I've been running L1P for a while now, with one instance being an OSC camera connected to an oldish Canon FD lens that has some longitudinal CA issues.
It turned out that I got a nice and sharp red channel, with the other two being mildly and strongly defocused. That is an issue that Rob Lancaster had spotted (and, AFAIR, taken care of) that for debayered images the first channel (=R) was used for focusing, which was changed to using the second one (=G). And I was quite sure I had tested it successfully before (at that time with Linear)
So my question is whether you do handling of image types in your code (and use the first channel), or if something else went wrong with that patch. Or I'm doing something wrong of course....
Pit
openSUSE Tumbleweed KStars git INDI git
GPDX+EQMOD, CEM60EC, ASI2600/1600/290mini+EFW+EAF
4 months 3 days ago #84826

Please Log in or Create an account to join the conversation.

Time to create page: 0.978 seconds