×
INDI Library v1.8.1 Released (09 Sep 2019)

Monthly maintenance release INDI v1.8.1

myFocuserPro or myFocuserPro2 and INDI

1 month 1 week ago
ChrisRowland
Gold Boarder
Gold Boarder
Posts: 215
Karma: 7
More
myFocuserPro or myFocuserPro2 and INDI #44365
Would it be worth being generous about what is accepted?

Take the string sent, remove the leading ':' and the trailing '#' and parse what is left as a decimal integer.
It could accept :8#, :08#, :008# and so on.
That way the code can be agnostic about the version of the code on the other side.

Chris
The following user(s) said Thank You knro

Please Log in or Create an account to join the conversation.

1 month 1 week ago
knro
Administrator
Administrator
Posts: 7378
Karma: 51
myFocuserPro or myFocuserPro2 and INDI #44370

ajt68 wrote: Roberto, I agree in principle that the sent command should be in the format #xx: where xx = leading zero 2 numeric (00-99), but rather than go back to change any that are not, just use this going forward.

I see you have modified the MaxPosition request back to #08:, unfortunately KNRO has submitted a change to #8:, without checking version of firmware (it would now be broke for 280, which wasted a bit of my time trying to understand why I was no longer reading the MaxPosition!)

Leave your change as is (#08:) in 291, and I will upgrade my focuser to 291, and retest, and fix any issue I see. I will then make the base firmware check equal to or greater than 291.

So to be clear:
KNRO to revert the :8# change back to :08# ;
Roberto, leave 291 as is (possibly point me at inputs or outputs they may have changed since 280?) ;
I will update to 291, test and fix ;


Does this seem acceptable?


Ok sorry I thought that was the actual fix to communicate with the firmware. Please agree on a solution and we'll take it from there.

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info

Please Log in or Create an account to join the conversation.

1 month 1 week ago
ajt68
Senior Boarder
Senior Boarder
Posts: 74
Karma: 1
More
myFocuserPro or myFocuserPro2 and INDI #44379
I have updated my focuser firmware to the latest 291, and set the Indi focuser driver to only work with 291 or greater.

I have made sure isMoving and Max position behave as expected.
I have implemented Reverse Motion, and removed option tab Reverse Direction (to use standard functions).

I am about to push these changes (this will also revert KNRO earlier change).
The following user(s) said Thank You Acapulco Rolf

Please Log in or Create an account to join the conversation.

1 month 1 week ago
ajt68
Senior Boarder
Senior Boarder
Posts: 74
Karma: 1
More
myFocuserPro or myFocuserPro2 and INDI #44382
So I have hit this problem, I have no idea what todo?!

alan@alan-kubuntu:~/indi$ git status
On branch master
Your branch and 'origin/master' have diverged,
and have 8 and 11 different commits each, respectively.
(use "git pull" to merge the remote branch into yours)
Changes to be committed:
(use "git reset HEAD <file>..." to unstage)

modified: drivers/focuser/myfocuserpro2.cpp
modified: drivers/focuser/myfocuserpro2.h

alan@alan-kubuntu:~/indi$ git commit -m "Update myFocuserPro2 to work with firmware 291 or greater"
[master 3874b71] Update myFocuserPro2 to work with firmware 291 or greater
2 files changed, 22 insertions(+), 31 deletions(-)
alan@alan-kubuntu:~/indi$ git pull
Auto-merging drivers/focuser/myfocuserpro2.cpp
CONFLICT (content): Merge conflict in drivers/focuser/myfocuserpro2.cpp
Automatic merge failed; fix conflicts and then commit the result.
alan@alan-kubuntu:~/indi$


How do I resolve this?

Please Log in or Create an account to join the conversation.

1 month 1 week ago
knro
Administrator
Administrator
Posts: 7378
Karma: 51
myFocuserPro or myFocuserPro2 and INDI #44386
I also fixed other issues in a prior commit, so this is why it complains. Just edit the file and manually fix the conflicts. or if you can create a PR then I'll resolve the conflicts myself.

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info

Please Log in or Create an account to join the conversation.

1 month 1 week ago
ajt68
Senior Boarder
Senior Boarder
Posts: 74
Karma: 1
More
myFocuserPro or myFocuserPro2 and INDI #44388
As stated many times before, I have never worked in git as a developer, and I am by no means a linux guru, so your previous comment really doesn't help me get any closer to a solution. My biggest concern is that I will loose my changes, by not really understanding what is going on, I also understand you are a very busy man, and don't have time to answer these sort of requests. Unfortunately I too am busy, and can't commit the time to learning git at this moment in time. Maybe we need a developer git help forum? I guess my problem was I didn't do a "git fetch" before starting my edits at lunch time?

After a bit of googling, I think I am back to some sort of synchronisation. You said "if I can create a PR....", I believe I already had, with a commit from myself, then one from you and now another from me just now. I manually opened the problem file with "nano" (horrible text editor) and then checked line by line looking for merge messages (there must be a better way of doing this?)

Anyway, I have done a commit. and my end says it is up to date, so I assume somehow I have muddled through and pushed my changes?

Please Log in or Create an account to join the conversation.

1 month 1 week ago
knro
Administrator
Administrator
Posts: 7378
Karma: 51
myFocuserPro or myFocuserPro2 and INDI #44430
Pretty much all developers hate GIT when they start working with it, then slowly comes in terms with its power. So everything is sorted out, thanks. Can you double check the code, is everything there?

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info

Please Log in or Create an account to join the conversation.

1 month 1 week ago
pyb
Fresh Boarder
Fresh Boarder
Posts: 10
More
myFocuserPro or myFocuserPro2 and INDI #44431
Hi everyone,

This is my first post.
I read carefully most of the threads on this forum since few months. In fact since I installed a RPi3b+, running Stellarmate as server for my astronomy equipment. I learn a lot and most of the time, I find answers to my questions. thanks to all for that.
I just received a "myFocuser Pro2" from Robert Brown in New Zeeland and I would like to test it, first via Kstars/Indi device manager and then, directly via ekos.
My problem is that I do not find the driver in the list of the focusers, even after having updated Indi... Probably I missed something :(

Thanks for your help,

Pierre-Yves

Pierre-Yves
SW 200/1000, Evostar 72ED, EOS-100D, HEQ5-Pro (Rowan belt kit),
MyFP2ProM/v2.91 focuser, Joystick 8BitDo-N30,
Rpi3B+/Stellarmate 1.4.5 server, Dell Inspiron 13.3/Linux Mint 19.2

Please Log in or Create an account to join the conversation.

1 month 1 week ago
knro
Administrator
Administrator
Posts: 7378
Karma: 51
myFocuserPro or myFocuserPro2 and INDI #44443
Hello Pierre-Yves,

Welcome to INDI forum. The focuser is not yet available in the stable release. It should be within a couple of weeks with the next stable release of INDI.

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info

Please Log in or Create an account to join the conversation.

1 month 1 week ago
pyb
Fresh Boarder
Fresh Boarder
Posts: 10
More
myFocuserPro or myFocuserPro2 and INDI #44444
Ok Jasem, thanks for your feedback. I was misled by the indi web page regarding this focuser that suggests that the driver is available.
Pierre-Yves

Pierre-Yves
SW 200/1000, Evostar 72ED, EOS-100D, HEQ5-Pro (Rowan belt kit),
MyFP2ProM/v2.91 focuser, Joystick 8BitDo-N30,
Rpi3B+/Stellarmate 1.4.5 server, Dell Inspiron 13.3/Linux Mint 19.2

Please Log in or Create an account to join the conversation.

1 month 1 week ago 1 month 1 week ago by knro.
knro
Administrator
Administrator
Posts: 7378
Karma: 51
myFocuserPro or myFocuserPro2 and INDI #44447
It is available in the INDI Nightly Builds.

The documentation says it is available INDI Library >= v1.8.2

Current stable INDI version is v1.8.1

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info

Please Log in or Create an account to join the conversation.

1 month 1 week ago
pyb
Fresh Boarder
Fresh Boarder
Posts: 10
More
myFocuserPro or myFocuserPro2 and INDI #44448
Sorry, I did'nt pay attention to the Indi release numbering.
Thanks Jasem.

Pierre-Yves
SW 200/1000, Evostar 72ED, EOS-100D, HEQ5-Pro (Rowan belt kit),
MyFP2ProM/v2.91 focuser, Joystick 8BitDo-N30,
Rpi3B+/Stellarmate 1.4.5 server, Dell Inspiron 13.3/Linux Mint 19.2

Please Log in or Create an account to join the conversation.

Time to create page: 0.738 seconds